Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTC-97 updates to OakMediaClipList and OakVideoTranscript component #334

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

weronika-szalas
Copy link
Contributor

@weronika-szalas weronika-szalas commented Dec 3, 2024

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

  • updated: OakMediaClipList - for keyboard navigation: the clip header minimise chevron should have visual feedback. Add focus state, similar to the one used for the "back to lesson" button
    PS. This affects one other component OakPupilJourneyUnitsFilter
  • OakMediaClipList - removed left border in desktop view (as we will add this border to video player instead so it stays also when the header is collapsed)
  • removed space on the left next to ‘Copy link’ button in mobile view in OakVideoTranscript component

Link to the design doc

A link to the component in the deployment preview

https://deploy-preview-334--lively-meringue-8ebd43.netlify.app/?path=/docs/components-organisms-teacher-oakmediacliplist--docs

Testing instructions

ACs

CTC-97

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit 6c49139
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/674edbaab5327c0007e0bd17
😎 Deploy Preview https://deploy-preview-334--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@weronika-szalas weronika-szalas changed the title CTC-57 updates to OakMediaClipList and OakVideoTranscript component CTC-97 updates to OakMediaClipList and OakVideoTranscript component Dec 3, 2024
Copy link

@weronika-szalas weronika-szalas marked this pull request as ready for review December 3, 2024 10:26
Copy link

@RBrownsett RBrownsett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - changes have been implemented

@weronika-szalas weronika-szalas merged commit 48ca93c into main Dec 3, 2024
9 checks passed
@weronika-szalas weronika-szalas deleted the feat/CTC-57-PR-feedback-style-updates branch December 3, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants