Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust max-width for OakDownloadsJourneyChildSubjectTierSelector component #314

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

assadk88
Copy link
Contributor

@assadk88 assadk88 commented Oct 24, 2024

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

I have set the maximum width of the inline banner of OakDownloadsJourneyChildSubjectTierSelector component to 640px

Link to the design doc

A link to the component in the deployment preview

https://deploy-preview-314--lively-meringue-8ebd43.netlify.app/?path=/docs/components-organisms-curriculum-oakdownloadsjourneychildsubjecttierselector--docs

Testing instructions

  1. Visit the deployment URL and use Chrome DevTools to verify that the maximum width of the inline banner for the OakDownloadsJourneyChildSubjectTierSelector component is 640px

ACs

  • Set the maximum width of the banner to 640px

Copy link

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit b4e0f13
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/671a5b078950fd0008b65922
😎 Deploy Preview https://deploy-preview-314--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Copy link

@HelenHarlow HelenHarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@rightsaidjames rightsaidjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as described

@assadk88 assadk88 merged commit 61eca81 into main Oct 28, 2024
8 checks passed
@assadk88 assadk88 deleted the feat/CUR-971/set-max-width-for-info-banner branch October 28, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants