Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export oak fieldset component #310

Merged
merged 1 commit into from
Oct 14, 2024
Merged

feat: export oak fieldset component #310

merged 1 commit into from
Oct 14, 2024

Conversation

k-huggs
Copy link
Contributor

@k-huggs k-huggs commented Oct 14, 2024

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Exports fieldset component

@k-huggs k-huggs requested review from njblore and carlmw October 14, 2024 10:33
@netlify Netlify
Copy link

netlify bot commented Oct 14, 2024 •
edited
Loading

✅ Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit b94d095
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/670cf363ec071600087c860a
😎 Deploy Preview https://deploy-preview-310--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

carlmw
carlmw approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@carlmw carlmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we really need a guard against this 😆 . I've done this so many times myself.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@k-huggs
Copy link
Contributor Author

k-huggs commented Oct 14, 2024

we really need a guard against this 😆 . I've done this so many times myself.

Every time 😂

@k-huggs k-huggs merged commit e16262a into main Oct 14, 2024
8 checks passed
@k-huggs k-huggs deleted the feat/export-oak-fieldset-component branch October 14, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlmw carlmw carlmw approved these changes

@njblore njblore Awaiting requested review from njblore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-huggs @carlmw