Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add subject cooking icon #308

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Feat/add subject cooking icon #308

merged 4 commits into from
Oct 10, 2024

Conversation

njblore
Copy link
Contributor

@njblore njblore commented Oct 10, 2024

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

  • update icon map with cooking and nutrition subject icon
  • also add swimming, this won't be a subject but the icon will live alongside the subject icons in cloudinary
  • note that until these icons are added in cloudinary the front end will display a missing image graphic (currently only present in search filters):
Screenshot 2024-10-10 at 13 24 56

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit ca5171f
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/6707c50086f86400079896f6
😎 Deploy Preview https://deploy-preview-308--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This reverts commit e989ce5.
Copy link

@njblore njblore marked this pull request as ready for review October 10, 2024 12:28
@njblore njblore requested review from JBR90 and k-huggs October 10, 2024 12:28
@njblore njblore merged commit 54493b9 into main Oct 10, 2024
6 checks passed
@njblore njblore deleted the feat/add-subject-cooking-icon branch October 10, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants