Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oakfieldset component #306

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Oakfieldset component #306

merged 6 commits into from
Oct 9, 2024

Conversation

k-huggs
Copy link
Contributor

@k-huggs k-huggs commented Oct 8, 2024 •
edited
Loading

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

Default <OakFieldset /> component

@netlify Netlify
Copy link

netlify bot commented Oct 8, 2024 •
edited
Loading

✅ Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit 33eec00
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/67054dc724e45900081e8a2c
😎 Deploy Preview https://deploy-preview-306--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k-huggs k-huggs marked this pull request as ready for review October 8, 2024 13:42
@k-huggs k-huggs requested review from njblore and carlmw October 8, 2024 13:44
carlmw
carlmw reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@carlmw carlmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably expose the same props as OakBox so i've made that suggestion

src/components/atoms/OakFieldset/OakFieldset.tsx Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@k-huggs k-huggs requested a review from carlmw October 9, 2024 09:54
carlmw
carlmw approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@carlmw carlmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨🏻‍🍳

@k-huggs k-huggs merged commit 1eb1daa into main Oct 9, 2024
8 checks passed
@k-huggs k-huggs deleted the feat/oak-fieldset-component branch October 9, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlmw carlmw carlmw approved these changes

@njblore njblore Awaiting requested review from njblore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-huggs @carlmw