Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/pupil journey units filter #229

Merged
merged 8 commits into from
Jul 16, 2024
Merged

Conversation

kimon-satan
Copy link
Collaborator

@kimon-satan kimon-satan commented Jul 15, 2024

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

A bunch of fixes to Accordians and the OakPupilJourneyUnitsFilter to make them suitable for pupil-760

  • OakPupilJourneyUnitsFilter has an interface which is not based on indexed position
  • Ensure Mobile Accordian stretches to full width of screen
  • Simply Components where there is redundancy
  • Improve nomenclature
  • Fix any minor style errors
  • Export test helpers which are now needed to support tests in OWA

A link to the component in the deployment preview

Testing instructions

ACs

Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit d1fcc14
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/66969725377d620008b668fa
😎 Deploy Preview https://deploy-preview-229--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kimon-satan kimon-satan requested a review from benprotheroe July 15, 2024 15:45
@kimon-satan kimon-satan marked this pull request as ready for review July 15, 2024 15:51
Copy link
Collaborator

@benprotheroe benprotheroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appoved with comments

Copy link

@kimon-satan kimon-satan merged commit e37c109 into main Jul 16, 2024
8 checks passed
@kimon-satan kimon-satan deleted the fix/pupil-journey-units-filter branch July 16, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants