Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change heading tag to h1 #226

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix: change heading tag to h1 #226

merged 1 commit into from
Jul 9, 2024

Conversation

njblore
Copy link
Contributor

@njblore njblore commented Jul 9, 2024 •
edited
Loading

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

@netlify Netlify
Copy link

netlify bot commented Jul 9, 2024 •
edited
Loading

✅ Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit f752e31
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/668d3ed2e56cee0008c52cb6
😎 Deploy Preview https://deploy-preview-226--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@njblore njblore marked this pull request as ready for review July 9, 2024 13:47
@njblore njblore requested a review from rightsaidjames July 9, 2024 13:47
@njblore njblore merged commit b13eb8b into main Jul 9, 2024
7 checks passed
@njblore njblore deleted the fix/lesq-831/header-hero-heading-level branch July 9, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rightsaidjames rightsaidjames rightsaidjames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njblore @rightsaidjames