-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PUPIL-838] Add OakInlineBanner component and tests #222
[PUPIL-838] Add OakInlineBanner component and tests #222
Conversation
✅ Deploy Preview for lively-meringue-8ebd43 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@BTitterington looking good - just want to check - for all of the banners labelled up 'simple' they show the link and dismiss button alongside the text rather than below - is that correct? Or should the link and the dismiss button be in the corners of the banner? |
@RBrownsett I just went off the design doc, although there was no mobile view that I could find (which does seem to make them look a little less appealing). Mike did take a quick look at them on Thursday and didn't spot anything other than an incorrect colour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - tested in mobile and across different browsers
@kimon-satan - related to our conversation earlier, I'm not sure if you think this should be an organism or molecule, happy to move it to organism if you think it's more appropriate there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice
How to review this PR
Leave this text block for the reviewer
Add your PR description below
Added new OakInlineBanner. It has 5 types - info, neutral, success, alert, error
It can also be overridden to change the icon and colours etc.
Link to the design doc
https://www.figma.com/design/YcWQMMhHPVVmc47cHHEEAl/%F0%9F%9F%A2-Oak-Design-Kit?node-id=9923-4249&m=dev
A link to the component in the deployment preview
https://deploy-preview-222--lively-meringue-8ebd43.netlify.app/?path=/docs/components-molecules-oakinlinebanner--docs
Testing instructions
Check the component is displayed and works as expected on desktop and mobile devices
Check accessibility of the component
ACs