Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUPIL-838] Add OakInlineBanner component and tests #222

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

BTitterington
Copy link
Contributor

@BTitterington BTitterington commented Jul 4, 2024

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

Added new OakInlineBanner. It has 5 types - info, neutral, success, alert, error
It can also be overridden to change the icon and colours etc.

Link to the design doc

https://www.figma.com/design/YcWQMMhHPVVmc47cHHEEAl/%F0%9F%9F%A2-Oak-Design-Kit?node-id=9923-4249&m=dev

A link to the component in the deployment preview

https://deploy-preview-222--lively-meringue-8ebd43.netlify.app/?path=/docs/components-molecules-oakinlinebanner--docs

Testing instructions

Check the component is displayed and works as expected on desktop and mobile devices
Check accessibility of the component

ACs

Copy link

Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit 7026479
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/668d2df9715a2d000852ec22
😎 Deploy Preview https://deploy-preview-222--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BTitterington BTitterington requested a review from RBrownsett July 8, 2024 07:54
@BTitterington BTitterington marked this pull request as ready for review July 8, 2024 07:54
@RBrownsett
Copy link

@BTitterington looking good - just want to check - for all of the banners labelled up 'simple' they show the link and dismiss button alongside the text rather than below - is that correct? Or should the link and the dismiss button be in the corners of the banner?

image

image

Copy link
Contributor Author

@RBrownsett I just went off the design doc, although there was no mobile view that I could find (which does seem to make them look a little less appealing). Mike did take a quick look at them on Thursday and didn't spot anything other than an incorrect colour.

Copy link

@RBrownsett RBrownsett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - tested in mobile and across different browsers

@BTitterington
Copy link
Contributor Author

@kimon-satan - related to our conversation earlier, I'm not sure if you think this should be an organism or molecule, happy to move it to organism if you think it's more appropriate there.

Copy link
Collaborator

@kimon-satan kimon-satan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@BTitterington BTitterington merged commit 473cd26 into main Jul 9, 2024
7 checks passed
@BTitterington BTitterington deleted the feat/PUPIL-838/create-inline-banner-component branch July 9, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants