Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve storybook entry #161

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

kimon-satan
Copy link
Collaborator

@kimon-satan kimon-satan commented May 8, 2024

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

A styled wrapper for OakPupilJourneyListItems

Link to the design doc

https://www.figma.com/file/zqpeecgzMGKRli2gUdJOLp/Pupil-Browse?type=design&node-id=4261%3A38039&mode=dev

A link to the component in the deployment preview

https://deploy-preview-161--lively-meringue-8ebd43.netlify.app/?path=/docs/components-organisms-pupil-oakpupiljourneylist--docs

ACs

[x] Renders children with correct styling
[x] Switches colour according to phase prop

Copy link

netlify bot commented May 8, 2024

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit b9d4d22
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/663b5c6b02948b0008c99f0c
😎 Deploy Preview https://deploy-preview-161--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kimon-satan kimon-satan marked this pull request as ready for review May 8, 2024 11:07
@kimon-satan kimon-satan requested a review from benprotheroe May 8, 2024 11:07
@kimon-satan kimon-satan merged commit a66ad81 into main May 8, 2024
5 checks passed
@kimon-satan kimon-satan deleted the feat/pupil-679/pupil-journey-list branch May 8, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants