Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add all subject icons #153

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Feat/add all subject icons #153

merged 3 commits into from
Apr 26, 2024

Conversation

JBR90
Copy link
Contributor

@JBR90 JBR90 commented Apr 26, 2024

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

-Removes some unwanted media query styling
-Adds lesson and unit search icons
-Adds keyIconColor prop

Link to the design doc

https://www.figma.com/file/hPCjH192PlemuDKRzz3JxM/Search?node-id=819%3A98630&mode=dev

A link to the component in the deployment preview

https://deploy-preview-153--lively-meringue-8ebd43.netlify.app/?path=/docs/components-organisms-teacher-oaksearchfiltercheckbox--docs

Testing instructions

Check icon color is the same on click when keepIconColor is true
Check that background color change on click when viewing as mobile

ACs

Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit 9e7c553
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/662b99dfaaec5b00089b54e6
😎 Deploy Preview https://deploy-preview-153--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JBR90 JBR90 requested review from k-huggs and njblore April 26, 2024 12:13
@JBR90 JBR90 merged commit d8ff90d into main Apr 26, 2024
5 checks passed
@JBR90 JBR90 deleted the feat/add-all-subject-icons branch April 26, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants