Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add exports for teacher #150

Merged
merged 1 commit into from
Apr 24, 2024
Merged

chore: add exports for teacher #150

merged 1 commit into from
Apr 24, 2024

Conversation

JBR90
Copy link
Contributor

@JBR90 JBR90 commented Apr 24, 2024

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

Adds exports for teacher components

Link to the design doc

A link to the component in the deployment preview

Testing instructions

ACs

Verified

This commit was signed with the committer’s verified signature. The key has expired.
xeho91 Mateusz Kadlubowski
@JBR90 JBR90 requested a review from njblore April 24, 2024 13:36
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit bd59541
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/66290aee0a62890008989790
😎 Deploy Preview https://deploy-preview-150--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JBR90 JBR90 requested a review from k-huggs April 24, 2024 13:37
@JBR90 JBR90 merged commit d3c2f79 into main Apr 24, 2024
4 checks passed
@JBR90 JBR90 deleted the chore-add-imports-for-teacher branch April 24, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants