Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-692 Add OakModal #137

Merged
merged 3 commits into from
Mar 28, 2024
Merged

ENG-692 Add OakModal #137

merged 3 commits into from
Mar 28, 2024

Conversation

carlmw
Copy link
Contributor

@carlmw carlmw commented Mar 27, 2024

How to review this PR

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

Screen.Recording.2024-03-27.at.12.19.54.mov

Link to the design doc

https://www.figma.com/file/8uwqYUIpTpyqdpSAVVV0g9/Oak-DS-Components?type=design&node-id=847-918612&mode=dev

A link to the component in the deployment preview

https://deploy-preview-137--lively-meringue-8ebd43.netlify.app/?path=/docs/components-molecules-oakmodal--docs

Testing instructions

ACs

  • Takes a11y cues from https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/examples/dialog/
    • Keyboard support
    • Focus locked within the modal when open
    • Relevant aria roles applied
  • Responsive at the 3 Oak breakpoints, mobile, tablet and desktop
  • Exported from oak-components as a molecule
  • Animates in from the left?
  • Footer sticks to the bottom of the viewport
    • Body can scroll
    • “Background” page cannot be scrolled while modal is active

Copy link

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit 5ca3942
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/6605421cbfb58b0008086158
😎 Deploy Preview https://deploy-preview-137--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@carlmw carlmw changed the title Feat/eng 692/modal ENG-692 Add OakModal Mar 27, 2024
@carlmw carlmw force-pushed the feat/ENG-692/modal branch 5 times, most recently from 80428f0 to 52cf6b7 Compare March 27, 2024 12:49
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@carlmw carlmw marked this pull request as ready for review March 27, 2024 13:22
Copy link
Collaborator

@kimon-satan kimon-satan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers from me .

@carlmw carlmw force-pushed the feat/ENG-692/modal branch from 52cf6b7 to 5ca3942 Compare March 28, 2024 10:10
@carlmw carlmw merged commit 2c63eb5 into main Mar 28, 2024
5 checks passed
@carlmw carlmw deleted the feat/ENG-692/modal branch March 28, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants