-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-692 Add OakModal
#137
Merged
Merged
ENG-692 Add OakModal
#137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lively-meringue-8ebd43 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
carlmw
force-pushed
the
feat/ENG-692/modal
branch
5 times, most recently
from
March 27, 2024 12:49
80428f0
to
52cf6b7
Compare
carlmw
commented
Mar 27, 2024
carlmw
commented
Mar 27, 2024
carlmw
commented
Mar 27, 2024
carlmw
commented
Mar 27, 2024
carlmw
commented
Mar 27, 2024
src/components/molecules/InternalShadowRoundButton/InternalShadowRoundButton.tsx
Outdated
Show resolved
Hide resolved
carlmw
commented
Mar 27, 2024
carlmw
commented
Mar 27, 2024
kimon-satan
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blockers from me .
carlmw
force-pushed
the
feat/ENG-692/modal
branch
from
March 28, 2024 10:10
52cf6b7
to
5ca3942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to review this PR
Add your PR description below
Screen.Recording.2024-03-27.at.12.19.54.mov
Link to the design doc
https://www.figma.com/file/8uwqYUIpTpyqdpSAVVV0g9/Oak-DS-Components?type=design&node-id=847-918612&mode=dev
A link to the component in the deployment preview
https://deploy-preview-137--lively-meringue-8ebd43.netlify.app/?path=/docs/components-molecules-oakmodal--docs
Testing instructions
ACs