fix: icons shrinking when in a flex context #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lively-meringue-8ebd43 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
carlmw
force-pushed
the
fix/draggable-icon-shrinking
branch
from
b6f6438 to
4b5f06a
Compare
carlmw
changed the title
OakDraggable flexing down when the text is long
4 tasks
we'll always want precise control over the dimensions of the icon, so we'll use min-width and min-height to prevent it from shrinking when in a flex container
carlmw
force-pushed
the
fix/draggable-icon-shrinking
branch
from
4b5f06a to
f653160
Compare
rightsaidjames
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Looks good - I tested the OakQuizOrder - With Many Options component at multiple breakpoints and confirmed that the sizing stayed consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to review this PR
Leave this text block for the reviewer
Description
This is a common bug where an icon is a direct descendent of a flex container it would shrink according to the flex algorithm — this change sets the min height and width to match the width and height ensuring that this won't happen.
We can reasonably expect that in all cases the icon shrinking would not be intentional and that we would expect to set the dimensions responsively when necessary for different breakpoints.
Before
After
A link to the component in the deployment preview
https://deploy-preview-130--lively-meringue-8ebd43.netlify.app/?path=/docs/components-atoms-oakicon--docs
https://deploy-preview-130--lively-meringue-8ebd43.netlify.app/?path=/docs/components-molecules-oakdraggable--docs