-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PUPIL-442: Match question UI #129
Conversation
this fixes the logo on the README being invisible when the client is in dark mode
…cedMotion` we'll need these for the match question
this is used in `OakQuizMatch` to hold the items that are to be matched
✅ Deploy Preview for lively-meringue-8ebd43 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
d0b79d9
to
d439f33
Compare
…items so they snap to the nearest drop zone when hitting the arrow keys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlmw looking & working great!
so the feedback will be read out by screen readers
Looks great! Tested on desktop and on mobile, with keyboard controls and with screen reader + keyboard. Hopefully minimal testing will be needed when integrated into OWA, but I might cast a slightly wider net for due diligence purposes. |
How to review this PR
Leave this text block for the reviewer
Add your PR description below
Adds UI for drag and drop match questions.
Link to the design doc
https://www.figma.com/file/G7z5ufo2T0CHk14CkadeuB/Pupils-high-fidelity-designs?type=design&node-id=6942-85574&mode=dev
A link to the component in the deployment preview
OakQuizMatch
https://deploy-preview-129--lively-meringue-8ebd43.netlify.app/?path=/docs/components-organisms-pupil-oakquizmatch--docsMakes changes to the drag and drop components to support both order and match
OakDraggable
https://deploy-preview-129--lively-meringue-8ebd43.netlify.app/?path=/docs/components-molecules-oakdraggable--docsOakDroppable
https://deploy-preview-129--lively-meringue-8ebd43.netlify.app/?path=/docs/components-molecules-oakdroppable--docsTesting instructions
ACs