Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUPIL-442: Match question UI #129

Merged
merged 15 commits into from
Mar 14, 2024
Merged

PUPIL-442: Match question UI #129

merged 15 commits into from
Mar 14, 2024

Conversation

carlmw
Copy link
Contributor

@carlmw carlmw commented Mar 8, 2024

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

Adds UI for drag and drop match questions.

Link to the design doc

https://www.figma.com/file/G7z5ufo2T0CHk14CkadeuB/Pupils-high-fidelity-designs?type=design&node-id=6942-85574&mode=dev

A link to the component in the deployment preview

OakQuizMatch https://deploy-preview-129--lively-meringue-8ebd43.netlify.app/?path=/docs/components-organisms-pupil-oakquizmatch--docs

Makes changes to the drag and drop components to support both order and match

OakDraggable https://deploy-preview-129--lively-meringue-8ebd43.netlify.app/?path=/docs/components-molecules-oakdraggable--docs
OakDroppable https://deploy-preview-129--lively-meringue-8ebd43.netlify.app/?path=/docs/components-molecules-oakdroppable--docs

Testing instructions

ACs

  • Items can be dragged into slots
  • Dragging an item onto an occupied slot the occupier is returned to the holding box
  • Items can be dragged back into the holding box
  • Items can be moved with similar keyboard controls to the option question UI

Copy link

Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit 5d09e06
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/65f1841a8625d40008938953
😎 Deploy Preview https://deploy-preview-129--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@carlmw carlmw force-pushed the feat/PUPIL-442/match-ui branch from d0b79d9 to d439f33 Compare March 8, 2024 12:48
@carlmw carlmw marked this pull request as ready for review March 11, 2024 12:06
Copy link

@messmike messmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlmw looking & working great!

@rightsaidjames
Copy link
Contributor

Looks great! Tested on desktop and on mobile, with keyboard controls and with screen reader + keyboard. Hopefully minimal testing will be needed when integrated into OWA, but I might cast a slightly wider net for due diligence purposes.

@carlmw carlmw merged commit 3449bb8 into main Mar 14, 2024
5 checks passed
@carlmw carlmw deleted the feat/PUPIL-442/match-ui branch March 14, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants