Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PUPIL-204): update drag and drop instructions #128

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

carlmw
Copy link
Contributor

@carlmw carlmw commented Mar 6, 2024

How to review this PR

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

instructions are more terse and no longer tailored to the detected input method.

Link to the design doc

https://www.figma.com/file/G7z5ufo2T0CHk14CkadeuB/Pupils-high-fidelity-designs?type=design&node-id=6942-116693&mode=design&t=9LOLhTBVKlvMIA6t-4

A link to the component in the deployment preview

https://deploy-preview-128--lively-meringue-8ebd43.netlify.app/?path=/docs/components-molecules-oakdraganddropinstructions--docs

Before

Desktop/keyboard

Screenshot 2024-03-06 at 15 52 08

Tablet/mobile/touch

Screenshot 2024-03-06 at 15 52 43

After

Screenshot 2024-03-06 at 15 54 22

instructions are more terse and no longer tailored to the detected input method.
Copy link

Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit a286d4c
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/65e890e74a25ba0009262e19
😎 Deploy Preview https://deploy-preview-128--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@carlmw carlmw marked this pull request as ready for review March 6, 2024 15:56
Copy link
Collaborator

@benprotheroe benprotheroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlmw carlmw merged commit 97ab00a into main Mar 7, 2024
5 checks passed
@carlmw carlmw deleted the feat/PUPIL-204/change-dnd-instructions branch March 7, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants