Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: tips for resuble code #125

Merged
merged 9 commits into from
Feb 28, 2024
Merged

docs: tips for resuble code #125

merged 9 commits into from
Feb 28, 2024

Conversation

kimon-satan
Copy link
Collaborator

Updated docs following mine and Carl's conversation this morning about best practice for reusing components

@kimon-satan kimon-satan marked this pull request as ready for review February 28, 2024 16:24
@netlify Netlify
Copy link

netlify bot commented Feb 28, 2024 •
edited
Loading

✅ Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit b0baa7e
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/65df61933f0d1c0007950503
😎 Deploy Preview https://deploy-preview-125--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kimon-satan kimon-satan requested a review from carlmw February 28, 2024 16:25
@rightsaidjames
Copy link
Contributor

tips for resuble code - does no one know how to spell today? 😄

rightsaidjames
rightsaidjames reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@rightsaidjames rightsaidjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assorted pedantry

src/docs/designingComponents.mdx Outdated Show resolved Hide resolved
src/docs/tipsForReusableCode.mdx Outdated Show resolved Hide resolved
src/docs/tipsForReusableCode.mdx Outdated Show resolved Hide resolved
src/docs/tipsForReusableCode.mdx Outdated Show resolved Hide resolved
src/docs/tipsForReusableCode.mdx Outdated Show resolved Hide resolved
src/docs/tipsForReusableCode.mdx Outdated Show resolved Hide resolved
src/docs/tipsForReusableCode.mdx Outdated Show resolved Hide resolved
src/docs/tipsForReusableCode.mdx Outdated Show resolved Hide resolved
kimon-satan and others added 5 commits February 28, 2024 16:34
@kimon-satan @rightsaidjames
Update src/docs/designingComponents.mdx
060597f 
Co-authored-by: James Sheasby Thomas <[email protected]>
@kimon-satan @rightsaidjames
Update src/docs/tipsForReusableCode.mdx
e5dd82d 
Co-authored-by: James Sheasby Thomas <[email protected]>
@kimon-satan @rightsaidjames
Update src/docs/tipsForReusableCode.mdx
f108e8c 
Co-authored-by: James Sheasby Thomas <[email protected]>
@kimon-satan @rightsaidjames
Update src/docs/tipsForReusableCode.mdx
9f74114 
Co-authored-by: James Sheasby Thomas <[email protected]>
@kimon-satan @rightsaidjames
Update src/docs/tipsForReusableCode.mdx
0cddeda 
Co-authored-by: James Sheasby Thomas <[email protected]>
@kimon-satan
Copy link
Collaborator Author

Assorted pedantry

Are you a bit short of work today James ?

kimon-satan and others added 3 commits February 28, 2024 16:38
@kimon-satan @rightsaidjames
Update src/docs/tipsForReusableCode.mdx
0621d19 
Co-authored-by: James Sheasby Thomas <[email protected]>
@kimon-satan @rightsaidjames
Update src/docs/tipsForReusableCode.mdx
ab3f718 
Co-authored-by: James Sheasby Thomas <[email protected]>
@kimon-satan @rightsaidjames
Update src/docs/tipsForReusableCode.mdx
b0baa7e 
Co-authored-by: James Sheasby Thomas <[email protected]>
rightsaidjames
rightsaidjames approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@rightsaidjames rightsaidjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you a bit short of work today James ?

You may think that, I couldn't possibly comment.

@carlmw
Copy link
Contributor

carlmw commented Feb 28, 2024

Are you a bit short of work today James ?

You may think that, I couldn't possibly comment.

captain-america-i-understood-that-reference

@kimon-satan kimon-satan merged commit e9536e9 into main Feb 28, 2024
5 checks passed
@kimon-satan kimon-satan deleted the feat/pupil-440/documentation branch February 28, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rightsaidjames rightsaidjames rightsaidjames approved these changes

@carlmw carlmw carlmw approved these changes

@benprotheroe benprotheroe Awaiting requested review from benprotheroe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimon-satan @rightsaidjames @carlmw