Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Allow CI to push updates to package.json #123

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

carlmw
Copy link
Contributor

@carlmw carlmw commented Feb 28, 2024

🎉 releases are now being published to NPM.

However the bump commit to update package.json with the new version number cannot be pushed to main because the branch is protected.

Following this doc https://github.com/semantic-release/semantic-release/blob/master/docs/recipes/ci-configurations/github-actions.md#pushing-packagejson-changes-to-a-master-branch I need someone with the power to add a repo secret GITHUB_TOKEN containing a Personal Access Token with the corresponding permissions to push to main bypassing the protected branch rules.

TODO

  • Add RELEASE_GITHUB_TOKEN to repo secrets

Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit adc1b71
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/65e0af4c29e54100084ddbff
😎 Deploy Preview https://deploy-preview-123--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@carlmw carlmw changed the title chore: don't persist checkout credentials in release workflow chore: Allow CI to push updates to package.json Feb 28, 2024
@carlmw carlmw marked this pull request as ready for review February 28, 2024 10:56
@carlmw carlmw merged commit b04f66d into main Feb 29, 2024
5 checks passed
@carlmw carlmw deleted the chore/dont-persist-checkout-credentials branch February 29, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant