Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUPIL-459 feat(copy-paste-this): create template component folder and files #119

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

benprotheroe
Copy link
Collaborator

created a new folder CopyPasteThisComponent

it is to be used as a template for new components which will hopefully help devs follow the conventions we have started for the library

the folder contains the following files
index.ts
CopyPasteThisComponent.tsx
CopyPasteThisComponent.stories.tsx
CopyPasteThisComponent.test.tsx

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit 1d544ad
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/65dde46a809ff6000816482d
😎 Deploy Preview https://deploy-preview-119--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@kimon-satan kimon-satan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very nice. Carl had a nice trick where you add comments to the props and they end up in the story could you add that to this too. Otherwise I'm happy with this.

@benprotheroe benprotheroe changed the title feat(copy-paste-this): create template component folder and files PUPIL-459 feat(copy-paste-this): create template component folder and files Feb 27, 2024
Copy link

@benprotheroe benprotheroe merged commit fdbcfa2 into main Feb 28, 2024
5 checks passed
@benprotheroe benprotheroe deleted the feat/PUPIL-440/copy-paste-this-component branch February 28, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants