Merge pull request #193 from oaknational/feat-plan-a-lesson-hero-

Feat plan a lesson hero author h to p
oaknational · May 23, 2024 · c27d083 · c27d083
2 parents ab7b960 + 06d313b
commit c27d083
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/src/components/organisms/OakHeaderHero/OakHeaderHero.tsx b/src/components/organisms/OakHeaderHero/OakHeaderHero.tsx
@@ -66,7 +66,6 @@ const UnstyledComponent = (props: OakHeaderHeroProps) => {
         >
           <OakFlex
             $alignSelf={"flex-start"}
-            $ph={"inner-padding-s"}
             $height={"100%"}
             $flexDirection={"column"}
           >
@@ -106,9 +105,7 @@ const UnstyledComponent = (props: OakHeaderHeroProps) => {
                   $zIndex={"in-front"}
                 />
                 <OakBox>
-                  <OakHeading tag="h3" $font={"heading-7"}>
-                    {authorName}
-                  </OakHeading>
+                  <OakP $font={"heading-7"}>{authorName}</OakP>
                   <OakP $font={"body-3"}>{authorTitle}</OakP>
                 </OakBox>
               </OakFlex>

diff --git a/src/components/organisms/OakHeaderHero/__snapshots__/OakHeaderHero.test.tsx.snap b/src/components/organisms/OakHeaderHero/__snapshots__/OakHeaderHero.test.tsx.snap
@@ -28,8 +28,6 @@ exports[`OakHeaderHero matches snapshot 1`] = `
 
 .c5 {
   height: 100%;
-  padding-left: 0.75rem;
-  padding-right: 0.75rem;
   font-family: Lexend,sans-serif;
 }
 
@@ -590,11 +588,11 @@ exports[`OakHeaderHero matches snapshot 1`] = `
             <div
               className="c18"
             >
-              <h3
+              <p
                 className="c19"
               >
                 Rachel Storm
-              </h3>
+              </p>
               <p
                 className="c20"
               >