-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: launch #61
feat: launch #61
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright e2e testsTo view traces locally, unzip the report and run: npx playwright show-report ~/Downloads/playwright-report |
@@ -162,26 +160,19 @@ export default function HomePage({ featureFlag }) { | |||
resources. | |||
</OakP> | |||
|
|||
{!userId || !featureFlag ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a functional change if the userId doesn't immediately load. I don't know if that can happen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was to do with creating a button saying coming soon or not weather the user was logged in
@@ -73,9 +70,6 @@ const Footer = ({ featureFlag }: FooterProps) => { | |||
} | |||
}} | |||
href={tool.href} | |||
disabled={ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about !tool.href
? Is href a required field now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The types allowed it to build so I assumed this was fine
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have those outstanding questions, but I think we can pick up any issues in testing
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This removes the pages for comparative judgment and the image alt text generator.
This also removes the feature flag opening aila up to the public and launching the project 🫨