Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: launch #61

Merged
merged 6 commits into from
Sep 4, 2024
Merged

feat: launch #61

merged 6 commits into from
Sep 4, 2024

Conversation

tomwisecodes
Copy link
Contributor

This removes the pages for comparative judgment and the image alt text generator.

This also removes the feature flag opening aila up to the public and launching the project 🫨

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 3:44pm

Copy link

github-actions bot commented Sep 4, 2024

Playwright e2e tests

Job summary

Download report

To view traces locally, unzip the report and run:

npx playwright show-report ~/Downloads/playwright-report

@@ -162,26 +160,19 @@ export default function HomePage({ featureFlag }) {
resources.
</OakP>

{!userId || !featureFlag ? (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a functional change if the userId doesn't immediately load. I don't know if that can happen

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was to do with creating a button saying coming soon or not weather the user was logged in

@@ -73,9 +70,6 @@ const Footer = ({ featureFlag }: FooterProps) => {
}
}}
href={tool.href}
disabled={
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about !tool.href? Is href a required field now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The types allowed it to build so I assumed this was fine

Copy link

sonarqubecloud bot commented Sep 4, 2024

Copy link
Collaborator

@codeincontext codeincontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have those outstanding questions, but I think we can pick up any issues in testing

@tomwisecodes tomwisecodes merged commit d9b19f7 into main Sep 4, 2024
12 checks passed
@tomwisecodes tomwisecodes deleted the feat/remove-feature-flag-protection branch September 4, 2024 15:45
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mantagen pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants