Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add stories for mobile pullout (AI-700) #470

Merged
merged 7 commits into from
Jan 8, 2025

Conversation

codeincontext
Copy link
Collaborator

@codeincontext codeincontext commented Jan 7, 2025

Description

Just a small story for an area without coverage. On desktop this component doesn't do much and its children each have fairly detailed tests. On mobile it has a little more logic which is worth testing

  • Add stories for mobile pullout

This PR depends on #469

Issue(s)

Fixes #AI-700

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 3:56pm

Copy link

github-actions bot commented Jan 7, 2025

Playwright test results

passed  17 passed
flaky  1 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  20 tests across 17 suites
duration  2 minutes, 43 seconds
commit  b16a06f

Flaky tests

No persona › tests/modifiy-lesson.test.ts › Modify a lesson plan › Modify a lesson resource

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI
No persona › tests/chat-performance.test.ts › Component renders during lesson chat › There are no unnecessary rerenders across left and right side of chat

@codeincontext codeincontext force-pushed the test/storybook-chromatic-modes branch from 8dd5931 to f07fe82 Compare January 8, 2025 10:16
@codeincontext codeincontext force-pushed the test/storybook-chromatic-modes branch from f07fe82 to 7aef0ef Compare January 8, 2025 10:22
@codeincontext codeincontext changed the title test: add stories for mobile pullout test: add stories for mobile pullout (AI-700) Jan 8, 2025
Copy link

@codeincontext codeincontext marked this pull request as ready for review January 8, 2025 10:24
@codeincontext codeincontext requested a review from a team January 8, 2025 10:25
Base automatically changed from test/storybook-chromatic-modes to main January 8, 2025 15:48
Copy link

sonarqubecloud bot commented Jan 8, 2025

@codeincontext codeincontext merged commit d89795d into main Jan 8, 2025
20 checks passed
@codeincontext codeincontext deleted the test/mobile-pullout branch January 8, 2025 18:21
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants