Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename LessonPlanKeys to LessonPlanKey #467

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Jan 7, 2025

Description

  • LessonPlanKeys plural should be LessonPlanKey singular, based on the principle of least surpriste
  • Renames this globally
  • Type-only update, no UX changes

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 3:09pm

Copy link

sonarqubecloud bot commented Jan 7, 2025

Copy link

github-actions bot commented Jan 7, 2025

Playwright test results

passed  17 passed
flaky  1 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  20 tests across 17 suites
duration  2 minutes, 56 seconds
commit  df695d7

Flaky tests

No persona › tests/modifiy-lesson.test.ts › Modify a lesson plan › Modify a lesson resource

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI
No persona › tests/chat-performance.test.ts › Component renders during lesson chat › There are no unnecessary rerenders across left and right side of chat

@stefl stefl requested a review from a team January 7, 2025 16:14
@stefl stefl merged commit fb071e7 into main Jan 7, 2025
18 checks passed
@stefl stefl deleted the fix/lesson_plan_key branch January 7, 2025 16:39
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants