Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use tighter "satisfies" typing in storybook #456

Merged
merged 2 commits into from
Dec 17, 2024
Merged

test: use tighter "satisfies" typing in storybook #456

merged 2 commits into from
Dec 17, 2024

Conversation

codeincontext
Copy link
Collaborator

See https://storybook.js.org/docs/writing-stories/typescript#using-satisfies-for-better-type-safety

  • Migrate all stories to satisfies type signature
  • Add types that were missing from stories
  • Remote props that aren't being used
  • Fix type error with MSW parameters

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 10:04am

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codeincontext
codeincontext commented Dec 17, 2024
View reviewed changes
apps/nextjs/src/components/AppComponents/Chat/chat-message/ChatMessagePart.tsx
@@ -34,7 +32,6 @@ const components = {
export interface ChatMessagePartProps {
part: MessagePart;
inspect: boolean;
moderationModalHelpers: ModerationModalHelpers;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These helpers aren't used in the function

@codeincontext codeincontext requested a review from a team December 17, 2024 10:12
@github-actions GitHub Actions
Copy link

Playwright test results

failed  1 failed
passed  13 passed
flaky  1 flaky
skipped  1 skipped

Details

report  Open report ↗︎
stats  16 tests across 15 suites
duration  10 minutes, 2 seconds
commit  6fdb9e7

Failed tests

Common persona - mobile › tests/aila-chat/full-romans.mobile.test.ts › Full aila flow with Romans fixture

Flaky tests

No persona › tests/modifiy-lesson.test.ts › Modify a lesson plan › Modify a lesson resource

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI

@codeincontext codeincontext merged commit 36a533d into main Dec 17, 2024
21 of 22 checks passed
@codeincontext codeincontext deleted the test/types-satisfies branch December 17, 2024 10:41
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBR90 JBR90 JBR90 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codeincontext @oak-machine-user @JBR90