fix: posthog consistent event properties #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright test results
Details
Skipped testsNo persona › tests/auth.test.ts › authenticate through Clerk UI |
Comment on lines
156
to
163
| for (const char of strippedMaybeKeyStage) { | ||
| str += char; | ||
| const startMatch = startKeyStageMap[str]; | ||
|
|
||
| if (startMatch) { | ||
| return startMatch; | ||
| } | ||
| } |
There was a problem hiding this comment.
I think you could also do this by looping Object.entries and comparing with startsWith. Could be clearer for people familiar with functional programming. Could be less clear for people who aren't I suppose!
codeincontext
approved these changes
Dec 11, 2024
|
|
🎉 This PR is included in version 1.18.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to test