Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dependency cruiser #438

Merged
merged 4 commits into from
Dec 11, 2024
Merged

chore: add dependency cruiser #438

merged 4 commits into from
Dec 11, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Dec 10, 2024

Description

  • Adds Dependency Cruiser
  • This allows us to statically analyse the dependencies in the project and find issues like:
    • Circular dependencies
    • Dev dependencies being used when they should be production
    • Orphan code that is no longer used

This just adds the package and we can run it locally with pnpm deps

It also makes a graph which is fun: pnpm deps:graph but a bit hard to understand at the moment!

dependency-graph

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 0:02am

Copy link

github-actions bot commented Dec 10, 2024

Playwright test results

passed  15 passed
skipped  1 skipped

Details

report  Open report ↗︎
stats  16 tests across 15 suites
duration  2 minutes, 3 seconds
commit  80dc8e2

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI

Copy link
Contributor

@JBR90 JBR90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That graph is mad!

@stefl stefl merged commit 392b422 into main Dec 11, 2024
17 checks passed
@stefl stefl deleted the chore/dep_cruiser branch December 11, 2024 12:10
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.18.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants