Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: temporarily disable no unsafe rules #429

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix: temporarily disable no unsafe rules #429

merged 1 commit into from
Dec 9, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Dec 9, 2024

Description

  • Temporarily disables two eslint rules which seem to be causing lots of false positives
  • Adds a rulesToDecideOn section in the eslint config:
"@typescript-eslint/no-unsafe-assignment": "off"
 "@typescript-eslint/no-unsafe-call": "off"

@vercel Vercel
Copy link

vercel bot commented Dec 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 8:39am

@stefl stefl requested review from JBR90 and a team December 9, 2024 08:36
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

Playwright test results

passed  15 passed
skipped  1 skipped

Details

report  Open report ↗︎
stats  16 tests across 15 suites
duration  2 minutes, 21 seconds
commit  4946638

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI

@stefl stefl merged commit a8ada5d into main Dec 9, 2024
18 checks passed
@stefl stefl deleted the fix/no_unsafe branch December 9, 2024 12:51
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.18.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mikeritson-oak mikeritson-oak mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeincontext codeincontext codeincontext approved these changes

@JBR90 JBR90 Awaiting requested review from JBR90

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefl @oak-machine-user @codeincontext