fix: update eslint config and lint errors #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JBR90
changed the title
Playwright test results
Details
Flaky testsNo persona › tests/modifiy-lesson.test.ts › Modify a lesson plan › Modify a lesson resource Skipped testsNo persona › tests/auth.test.ts › authenticate through Clerk UI |
stefl
approved these changes
Dec 4, 2024
| @@ -3,6 +3,7 @@ import { useRef, useState } from "react"; | |||
| import { OakPrimaryButton } from "@oaknational/oak-components"; | |||
| import { Flex } from "@radix-ui/themes"; | |||
| import type { Survey } from "posthog-js"; | |||
| import { SurveyQuestionType } from "posthog-js"; | |||
There was a problem hiding this comment.
Is this a type? So import type?
There was a problem hiding this comment.
It's an enum so cannot be imported as a type
| @@ -3,6 +3,7 @@ import { useEffect, useState, useCallback } from "react"; | |||
| import { aiLogger } from "@oakai/logger"; | |||
| import * as Sentry from "@sentry/react"; | |||
| import type { Survey } from "posthog-js"; | |||
| import { SurveyType } from "posthog-js"; | |||
|
|
🎉 This PR is included in version 1.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"no-extra-boolean-cast": "error",
"no-useless-escape": "error",
"no-unsafe-finally": "error",
"no-prototype-builtins": "error",
"@typescript-eslint/no-unsafe-enum-comparison"
"@typescript-eslint/restrict-template-expressions": "error",
"@typescript-eslint/await-thenable": "error",
Issue(s)
How to test
Should all work as before
Checklist