Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not define components inline #413

Merged
merged 2 commits into from
Nov 28, 2024
Merged

fix: do not define components inline #413

merged 2 commits into from
Nov 28, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Nov 28, 2024

Description

  • Fixes a sonar complaint about defining components inline

Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 5:06pm

@stefl stefl requested a review from a team November 28, 2024 17:02
Copy link
Collaborator

@codeincontext codeincontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link

Playwright test results

passed  15 passed
skipped  1 skipped

Details

report  Open report ↗︎
stats  16 tests across 15 suites
duration  2 minutes, 14 seconds
commit  27c8e4d

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI

@stefl stefl merged commit abda175 into main Nov 28, 2024
20 checks passed
@stefl stefl deleted the fix/comp_defs branch November 28, 2024 17:31
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.17.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants