Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not use array index for key / use void for onSubmit #409

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Nov 28, 2024

Description

  • Fixes a small issue with using an array for the key of a repeated set of items
  • Fixes a missing "void"s in the same files

Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 3:08pm

Copy link

Playwright test results

passed  14 passed
flaky  1 flaky
skipped  1 skipped

Details

report  Open report ↗︎
stats  16 tests across 15 suites
duration  2 minutes, 33 seconds
commit  e5355a0

Flaky tests

No persona › tests/modifiy-lesson.test.ts › Modify a lesson plan › Modify a lesson resource

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI

@stefl stefl requested a review from a team November 28, 2024 16:23
.map((c) => String(c))
.map((category) => (
<span
key={category}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this always unique?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we have a set of categories that the moderation can flag

@stefl stefl merged commit 44b5961 into main Nov 28, 2024
22 checks passed
@stefl stefl deleted the fix/no_array_index branch November 28, 2024 18:00
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.17.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants