Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sonar maintain issues #4 #405

Merged
merged 16 commits into from
Nov 28, 2024
Merged

fix: sonar maintain issues #4 #405

merged 16 commits into from
Nov 28, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Nov 28, 2024

Description

  • Addresses a handful more sonar issues marked maintain

@vercel Vercel
Copy link

vercel bot commented Nov 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 3:19pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Playwright test results

passed  15 passed
skipped  1 skipped

Details

report  Open report ↗︎
stats  16 tests across 15 suites
duration  2 minutes, 16 seconds
commit  4175a05

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI

@stefl stefl requested a review from a team November 28, 2024 14:29
codeincontext
codeincontext approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@codeincontext codeincontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of details but otherwise approved

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stefl stefl merged commit eca0019 into main Nov 28, 2024
16 checks passed
@stefl stefl deleted the fix/sonar_maintain_4 branch November 28, 2024 15:25
@mikeritson-oak mikeritson-oak mentioned this pull request Dec 2, 2024
Merged
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.17.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeincontext codeincontext codeincontext approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefl @oak-machine-user @codeincontext