Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert tabindex change #404

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix: revert tabindex change #404

merged 1 commit into from
Nov 28, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Nov 28, 2024

Description

  • I accepted a Sonar rule to not have positive integer tabindex values
  • This changed UX for keyboard navigation
  • So this reverts it and we can address this in a different way later

@vercel Vercel
Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 9:02am

@stefl stefl requested a review from a team November 28, 2024 09:03
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 28, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
3 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stefl stefl merged commit ac72713 into main Nov 28, 2024
14 of 17 checks passed
@stefl stefl deleted the fix/revert_tabindex branch November 28, 2024 09:06
@mikeritson-oak mikeritson-oak mentioned this pull request Dec 2, 2024
Merged
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.17.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeincontext codeincontext codeincontext approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefl @oak-machine-user @codeincontext