test: stories for supplementary chat messages #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
codeincontext
commented
Nov 27, 2024
codeincontext
commented
- Extract demo limit message from chat list file, and add a story
- Extract download buttons from chat list, and add a story
- Change the paths of some other stories to fit in
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright test results
Details
Flaky testsNo persona › tests/modifiy-lesson.test.ts › Modify a lesson plan › Modify a lesson resource Skipped testsNo persona › tests/auth.test.ts › authenticate through Clerk UI |
codeincontext
commented
Nov 28, 2024
| @@ -45,7 +45,6 @@ export const decorators: Decorator[] = [ | |||
| ClerkDecorator, | |||
| (Story) => ( | |||
| <> | |||
| {/* TODO: Mock tRPC calls with MSW */} | |||
There was a problem hiding this comment.
We are doing this now
codeincontext
commented
Nov 28, 2024
Comment on lines
-26
to
-43
| function DemoLimitMessage({ id }: Readonly<{ id: string }>) { | ||
| return ( | ||
| <div className="w-full flex-col gap-11"> | ||
| <ChatMessage | ||
| chatId={id} | ||
| ailaStreamingStatus="Idle" | ||
| message={{ | ||
| id: "demo-limit", | ||
| role: "assistant", | ||
| content: | ||
| '{"type": "error", "message": "**Your lesson is complete**\\nYou can no longer edit this lesson. [Create new lesson.](/aila)"}', | ||
| }} | ||
| persistedModerations={[]} | ||
| separator={<span className="my-10 flex" />} | ||
| /> | ||
| </div> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Extracted to a new file and story
codeincontext
commented
Nov 28, 2024
Comment on lines
-236
to
-298
| const InChatDownloadButtons = ({ | ||
| demo, | ||
| id, | ||
| setDialogWindow, | ||
| }: { | ||
| readonly demo: DemoContextProps; | ||
| readonly id: string; | ||
| readonly setDialogWindow: Dispatch<SetStateAction<DialogTypes>>; | ||
| }) => { | ||
| return ( | ||
| <OakFlex $flexDirection="column" $gap="all-spacing-7" $mv="space-between-l"> | ||
| {demo.isSharingEnabled && ( | ||
| <Link | ||
| href={demo.isSharingEnabled ? `/aila/download/${id}` : "#"} | ||
| onClick={() => { | ||
| if (!demo.isSharingEnabled) { | ||
| setDialogWindow("demo-share-locked"); | ||
| } | ||
| }} | ||
| > | ||
| <InnerInChatButton iconName="download">Download</InnerInChatButton> | ||
| </Link> | ||
| )} | ||
| <button | ||
| onClick={() => { | ||
| if (demo.isSharingEnabled) { | ||
| setDialogWindow("share-chat"); | ||
| } else { | ||
| setDialogWindow("demo-share-locked"); | ||
| } | ||
| }} | ||
| > | ||
| <InnerInChatButton iconName="share">Share</InnerInChatButton> | ||
| </button> | ||
| </OakFlex> | ||
| ); | ||
| }; | ||
|
|
||
| const InnerInChatButton = ({ | ||
| iconName, | ||
|
|
||
| children, | ||
| }: { | ||
| readonly iconName: "download" | "share"; | ||
|
|
||
| readonly children: string; | ||
| }) => { | ||
| return ( | ||
| <OakFlex | ||
| $pa="inner-padding-m" | ||
| $gap="all-spacing-3" | ||
| $background="white" | ||
| $borderRadius="border-radius-m" | ||
| $alignItems="center" | ||
| $dropShadow="drop-shadow-standard" | ||
| > | ||
| <OakBox $transform="scale"> | ||
| <OakIcon iconName={iconName} $width="all-spacing-7" /> | ||
| </OakBox> | ||
| <OakSpan $font="body-2">{children}</OakSpan> | ||
| </OakFlex> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Extracted to a new file and story
|
mikeritson-oak
approved these changes
Nov 28, 2024
JBR90
reviewed
Nov 28, 2024
| @@ -3,7 +3,7 @@ import type { Meta, StoryObj } from "@storybook/react"; | |||
| import { ChatStartForm } from "./chat-start-form"; | |||
|
|
|||
| const meta: Meta<typeof ChatStartForm> = { | |||
| title: "Components/Chat/ChatStartForm", | |||
| title: "Components/Chat Start/ChatStartForm", | |||
There was a problem hiding this comment.
Is that path meant to have a gap? Chat Start
There was a problem hiding this comment.
Thanks for checking. This is only used in the storybook UI so it does look right there
JBR90
approved these changes
Nov 28, 2024
|
🎉 This PR is included in version 1.17.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.