Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add linting command to db package #392

Merged
merged 4 commits into from
Nov 27, 2024
Merged

fix: add linting command to db package #392

merged 4 commits into from
Nov 27, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Nov 27, 2024 •
edited
Loading

Description

  • Adds pnpm lint and type-check commands to the db package which were missing
  • Fixes some small linting isses in the db package
  • Marks more complex issues that require a refactor as ignore for now
  • Unfortunately this means our sonar error count will go up most probably :-(
  • Adjusts the CI process for linting to use no-engine and run it as a separate step

@vercel Vercel
Copy link

vercel bot commented Nov 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 11:21am

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

Playwright test results

passed  15 passed
skipped  1 skipped

Details

report  Open report ↗︎
stats  16 tests across 15 suites
duration  2 minutes, 1 second
commit  626ee39

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stefl stefl requested a review from a team November 27, 2024 11:20
codeincontext
codeincontext reviewed Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@codeincontext codeincontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I like the idea of ignoring older lint errors rather then getting sucked into fixing them all immediately

@stefl
Copy link
Contributor Author

stefl commented Nov 27, 2024

Looks good to me. I like the idea of ignoring older lint errors rather then getting sucked into fixing them all immediately

Sonar recommends that as an approach - focus on new code first.

@stefl stefl merged commit d2177d5 into main Nov 27, 2024
20 checks passed
@stefl stefl deleted the fix/lint_db branch November 27, 2024 11:31
@mikeritson-oak mikeritson-oak mentioned this pull request Dec 2, 2024
Merged
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.17.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeincontext codeincontext codeincontext approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefl @oak-machine-user @codeincontext