Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor linting #384

Merged
merged 31 commits into from
Nov 26, 2024
Merged

fix: minor linting #384

Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
5c6c6c1
fix: typo in lesson sections
stefl Nov 26, 2024
aa3d48e
fix: use option chain
stefl Nov 26, 2024
5f2fcf8
fix: use option chain and scrollY
stefl Nov 26, 2024
d47d8d3
fix: use scrollY
stefl Nov 26, 2024
a592928
fix: remove empty fragment
stefl Nov 26, 2024
75ba7de
fix: option chain and scrollY
stefl Nov 26, 2024
a1d0a41
fix: option chain
stefl Nov 26, 2024
0c5d240
fix: nullish coalescing
stefl Nov 26, 2024
7347b03
fix: remove unused import
stefl Nov 26, 2024
1c17303
Add proptypes to img mock
stefl Nov 26, 2024
ee24e6a
Add cspell ignore
stefl Nov 26, 2024
7066afc
Remove unused import
stefl Nov 26, 2024
9d0f494
Use option chain for match
stefl Nov 26, 2024
80c3585
Remove unused return
stefl Nov 26, 2024
4d72aa5
Set attributes as readonly on Aila
stefl Nov 26, 2024
6df4385
Combine type imports in AilaChat
stefl Nov 26, 2024
91a844c
Set attributes to readonly in AilaStreamHandler
stefl Nov 26, 2024
6cdd2be
Set attributes as readonly in AilaLesson
stefl Nov 26, 2024
ddf1a4e
Set responseObject to readonly in MockLLMService
stefl Nov 26, 2024
c86f7ab
Simplify boolean logic in OpenAIService
stefl Nov 26, 2024
a600259
Simplify boolean logic in AilaLessonPromptBuilder
stefl Nov 26, 2024
e600fd0
Set attributes as readonly in AilaAnalytics
stefl Nov 26, 2024
e6dce0c
Set Attributes as readonly in DataDogAnalyticsAdapter
stefl Nov 26, 2024
baf0001
Set attributes as readonly in PosthogAnalytics Adapter
stefl Nov 26, 2024
772fd12
Do not allow string in SpeakerNotesTag type
stefl Nov 26, 2024
67cc177
Add a todo fo the speaker notes tag type
stefl Nov 26, 2024
e9f76e4
Revert mock service worker linting
stefl Nov 26, 2024
674567c
Ignore generated service worker
stefl Nov 26, 2024
eedea61
Merge branch 'main' into fix/minor_linting
stefl Nov 26, 2024
b60dc24
Merge remote-tracking branch 'origin/main' into fix/minor_linting
stefl Nov 26, 2024
d056058
Merge branch 'fix/minor_linting' of https://github.com/oaknational/oa…
stefl Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,15 @@
],
"typescript.tsdk": "node_modules/typescript/lib",
"typescript.enablePromptUseWorkspaceTsdk": true,
"cSpell.ignorePaths": [
"pnpm-lock.json",
"node_modules",
"vscode-extension",
".git/{info,lfs,logs,refs,objects}/**",
".git/{index,*refs,*HEAD}",
".vscode",
".vscode-insiders"
],
"cSpell.words": [
"Aila",
"APIV",
Expand All @@ -33,6 +42,7 @@
"COLOR",
"compat",
"contrib",
"corejs",
"cuid",
"dashify",
"datadoghq",
Expand All @@ -45,6 +55,7 @@
"dopplerhq",
"dotenv",
"EASS",
"Edtech",
"EHRC",
"estree",
"estruyf",
Expand Down Expand Up @@ -132,10 +143,13 @@
"rushstack",
"Sedar",
"slidedeck",
"sslcert",
"sslmode",
"SUBJ",
"superjson",
"svgs",
"svix",
"systemjs",
"tailwindcss",
"tanstack",
"testid",
Expand Down
Loading
Loading