Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: soft delete #383

Merged
merged 30 commits into from
Dec 17, 2024
Merged

feat: soft delete #383

merged 30 commits into from
Dec 17, 2024

Conversation

tomwisecodes
Copy link
Contributor

@tomwisecodes tomwisecodes commented Nov 26, 2024

Description

  • Center text in dialogs for clearing chat
  • Stops user from hard deleting chat and rather adds a flag to the database
  • Stops get chat methods from finding soft delted chats

contains migration

how to test:

  • delteing a chat works as expected
  • the text in the dialog is centered on mobile

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 2:03pm

Copy link
Collaborator

@mantagen mantagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

Copy link

github-actions bot commented Nov 26, 2024

Playwright test results

passed  14 passed
flaky  1 flaky
skipped  1 skipped

Details

report  Open report ↗︎
stats  16 tests across 15 suites
duration  2 minutes, 40 seconds
commit  0c32da6

Flaky tests

No persona › tests/modifiy-lesson.test.ts › Modify a lesson plan › Modify a lesson resource

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI

Copy link
Collaborator

@mikeritson-oak mikeritson-oak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soft delete checked in the frontend and the DB with help from @mantagen. Looks good. 👍

@tomwisecodes tomwisecodes merged commit 9dee4ad into main Dec 17, 2024
20 checks passed
@tomwisecodes tomwisecodes deleted the feat/soft-delete branch December 17, 2024 09:33
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants