Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: svg clip-rule should be clipRule in JSX #382

Merged
merged 1 commit into from
Nov 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
"EHRC",
"estree",
"estruyf",
"evenodd",
"eyfs",
"firstname",
"fkey",
Expand Down Expand Up @@ -123,6 +124,7 @@
"psql",
"pusherapp",
"ratelimit",
"rect",
"refs",
"Regen",
"remeda",
Expand Down
20 changes: 10 additions & 10 deletions apps/nextjs/src/components/Feedback/Smiley.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ const Smiley = ({ selected, number }: SmileyProps) => {
fill={color}
/>
<path
fill-rule="evenodd"
clip-rule="evenodd"
fillRule="evenodd"
clipRule="evenodd"
d="M42.5 20.5C42.5 31.8218 33.0981 41 21.5 41C9.90195 41 0.5 31.8218 0.5 20.5C0.5 9.17818 9.90195 0 21.5 0C33.0981 0 42.5 9.17818 42.5 20.5ZM39.6034 20.5C39.6034 30.2602 31.4983 38.1724 21.5 38.1724C11.5017 38.1724 3.39655 30.2602 3.39655 20.5C3.39655 10.7398 11.5017 2.82759 21.5 2.82759C31.4983 2.82759 39.6034 10.7398 39.6034 20.5Z"
fill={color}
/>
Expand Down Expand Up @@ -57,8 +57,8 @@ const Smiley = ({ selected, number }: SmileyProps) => {
fill={color}
/>
<path
fill-rule="evenodd"
clip-rule="evenodd"
fillRule="evenodd"
clipRule="evenodd"
d="M41.5 20.5C41.5 31.8218 32.3219 41 21 41C9.67809 41 0.5 31.8218 0.5 20.5C0.5 9.17818 9.67809 0 21 0C32.3219 0 41.5 9.17818 41.5 20.5ZM38.6724 20.5C38.6724 30.2602 30.7602 38.1724 21 38.1724C11.2398 38.1724 3.32759 30.2602 3.32759 20.5C3.32759 10.7398 11.2398 2.82759 21 2.82759C30.7602 2.82759 38.6724 10.7398 38.6724 20.5Z"
fill={color}
/>
Expand Down Expand Up @@ -87,8 +87,8 @@ const Smiley = ({ selected, number }: SmileyProps) => {
fill={color}
/>
<path
fill-rule="evenodd"
clip-rule="evenodd"
fillRule="evenodd"
clipRule="evenodd"
d="M42.5 20.5C42.5 31.8218 33.098 41 21.5 41C9.90202 41 0.5 31.8218 0.5 20.5C0.5 9.17816 9.90202 0 21.5 0C33.098 0 42.5 9.17816 42.5 20.5ZM39.6034 20.5C39.6034 30.2602 31.4983 38.1724 21.5 38.1724C11.5017 38.1724 3.39655 30.2602 3.39655 20.5C3.39655 10.7398 11.5017 2.82759 21.5 2.82759C31.4983 2.82759 39.6034 10.7398 39.6034 20.5Z"
fill={color}
/>
Expand Down Expand Up @@ -117,8 +117,8 @@ const Smiley = ({ selected, number }: SmileyProps) => {
fill={color}
/>
<path
fill-rule="evenodd"
clip-rule="evenodd"
fillRule="evenodd"
clipRule="evenodd"
d="M41.5 20.5C41.5 31.8218 32.3219 41 21 41C9.67809 41 0.5 31.8218 0.5 20.5C0.5 9.17818 9.67809 0 21 0C32.3219 0 41.5 9.17818 41.5 20.5ZM38.6724 20.5C38.6724 30.2602 30.7602 38.1724 21 38.1724C11.2398 38.1724 3.32759 30.2602 3.32759 20.5C3.32759 10.7398 11.2398 2.82759 21 2.82759C30.7602 2.82759 38.6724 10.7398 38.6724 20.5Z"
fill={color}
/>
Expand Down Expand Up @@ -147,8 +147,8 @@ const Smiley = ({ selected, number }: SmileyProps) => {
fill={color}
/>
<path
fill-rule="evenodd"
clip-rule="evenodd"
fillRule="evenodd"
clipRule="evenodd"
d="M41.5 20.5C41.5 31.8218 32.3218 41 21 41C9.67816 41 0.5 31.8218 0.5 20.5C0.5 9.17816 9.67816 0 21 0C32.3218 0 41.5 9.17816 41.5 20.5ZM38.6724 20.5C38.6724 30.2602 30.7602 38.1724 21 38.1724C11.2398 38.1724 3.32759 30.2602 3.32759 20.5C3.32759 10.7398 11.2398 2.82759 21 2.82759C30.7602 2.82759 38.6724 10.7398 38.6724 20.5Z"
fill={color}
/>
Expand Down
Loading