test: stories for dialogs #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright test results
Details
Skipped testsNo persona › tests/auth.test.ts › authenticate through Clerk UI |
codeincontext
force-pushed
the
test/dialogs
branch
from
1871c00 to
a922693
Compare
codeincontext
force-pushed
the
test/dialogs
branch
from
9fbc3e6 to
57fd799
Compare
codeincontext
force-pushed
the
test/dialogs
branch
from
57fd799 to
7150757
Compare
codeincontext
commented
Nov 19, 2024
| @@ -35,7 +35,7 @@ const dialogTitlesAndIcons: Record< | |||
| iconName: "warning", | |||
| }, | |||
| "demo-interstitial": { | |||
| title: "Lesson limit reached", | |||
| title: "Demo lesson limits", | |||
There was a problem hiding this comment.
This is a copy change, as the previous title was inccorect a lot of the time
There was a problem hiding this comment.
@mikeritson-oak it might be worth checking this
codeincontext
commented
Nov 19, 2024
codeincontext
commented
Nov 19, 2024
| @@ -0,0 +1,295 @@ | |||
| /* eslint-disable */ | |||
There was a problem hiding this comment.
This is autogenerated
|
|
🎉 This PR is included in version 1.16.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds stories for each of our dialogs. Each dialog has a component, but we interact with them through the DialogContents component. I figured it made sense to test through that interface
Mocking providers
Some of the dialogs need some mocked data from posthog, the demo status, or the demo API call. For the time being I've mocked each of these at the highest point possible, to help with coverage. eg: Mock the tRPC call from the DemoProvider, rather than mocking the DemoProvider itself. These patterns might change in the future as we learn more about storybook and have more tests in place
MSW (Mock Service Worker)
This is the recommended way to mock network requests in storybook. It seems to work really nicely out of the box
Snapshots
You can see the story changes in chromatic