test: add storybook stories for public pages #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
codeincontext
force-pushed
the
test/public-stories
branch
from
1af6ade to
f63ed12
Compare
codeincontext
commented
Nov 14, 2024
codeincontext
commented
Nov 14, 2024
| @@ -48,90 +48,94 @@ const Prompts = ({ apps }: PromptsPageData) => { | |||
| }, [pathname, itemRefs]); | |||
|
|
|||
| return ( | |||
| <Layout> | |||
There was a problem hiding this comment.
The only change here is removing <Layout>
Playwright test results
Details
Skipped testsNo persona › tests/auth.test.ts › authenticate through Clerk UI |
codeincontext
commented
Nov 14, 2024
| @@ -1,7 +1,7 @@ | |||
| export interface PolicyDocument { | |||
| title: string; | |||
| slug: string; | |||
| fake_updatedAt: string; | |||
| fake_updatedAt: string | null; | |||
There was a problem hiding this comment.
The fixture data was failing the type
codeincontext
force-pushed
the
test/public-stories
branch
from
7a6e4f1 to
95ba18a
Compare
|
mikeritson-oak
approved these changes
Nov 15, 2024
|
🎉 This PR is included in version 1.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds storybook stories for each of our public pages
In the long run we might want more targeted stories for the atoms and molecules which make up pages, but for now this is a good way to get test coverage
For each page I've created an inner
MyPageContentcomponent without the<Layout>wrapper. We want to test the layout independently. This has caused large diffs due to the indentation change, but there actually isn't that much being changed