-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow for quiz exports to handle images #357
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright test resultsDetails Open report ↗︎ Failed testsCommon persona › tests/aila-chat/downloads.test.ts › Downloading a completed lesson plan Skipped testsNo persona › tests/auth.test.ts › authenticate through Clerk UI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done some initial tests in Chrome and getting varying results when trying to export the resources.
- First lesson, new, failed to export warnings on all
- Second lesson, old, selected items downloaded
- First lesson (retry), some downloaded then warnings again
The warnings/failures seem sporadic, some generate/download, others fail. No errors or warnings seen in the console at time of download.
@tomwisecodes I think importantly for this work to go in, we need it to be able to handle markdown images inline in questions or answers/distractors: {
question: "Complete the statement. Triangle ABC and triangle XYZ are ____________. ![image](http://oaknationalacademy-res.cloudinary.com/image/upload/v1706110974/fukcqeavzcevgjhmm1n4.png)",
answers: ["similar as the three interior angles are the same."],
distractors: [
"congruent as the three interior angles are all the same.",
"neither similar nor congruent.",
],
} |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well!
documentId: string; | ||
data: Data; | ||
}) { | ||
// The method here is too locate the placeholder in the documents, delete it, and insert the image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// The method here is too locate the placeholder in the documents, delete it, and insert the image. | |
// The method here is to locate the placeholder in the documents, delete it, and insert the image. |
Closing in favour of #400 |
Description
This allows for all of our doc exports to be able to handle export images. This work precedes the maths quiz questions work which will call on oak maths questions where the questions and answers are often in image form. The logic may also be reused in the future for adding images to slides.
How to test:
In order to test this run through the download process for a quiz and it should work with no changes