-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add FeatureFlagProvider #353
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5d7cf5a
to
2ee5d29
Compare
2ee5d29
to
f72fa5d
Compare
Quality Gate passedIssues Measures |
Playwright test resultsDetails Open report ↗︎ Skipped testsNo persona › tests/auth.test.ts › authenticate through Clerk UI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested the 'cool new feature' and worked as expected
Great. Thanks Joe |
🎉 This PR is included in version 1.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
In #320 we added server-side generation of feature flags. That populated the initial flags bootstrapped on posthog.init, and we could then query posthog to get the feature flag status
It turns out that this has two problems:
This PR:
Testing: