-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: set up chromatic config and get storybook building #344
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright test resultsDetails Open report ↗︎ Skipped testsNo persona › tests/auth.test.ts › authenticate through Clerk UI |
5c30d12
to
260e9f7
Compare
260e9f7
to
25a2dfd
Compare
// Providers not currently used | ||
// - MockClerkProvider | ||
// - CookieConsentProvider | ||
// - DemoProvider | ||
// - LessonPlanTrackingProvider | ||
// - DialogProvider | ||
// - OakThemeProvider | ||
// - SidebarProvider | ||
// - ChatModerationProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of these providers was causing an error looking up text-primary
. For the time being, it looks like none of our current stories need them
As we add more stories, we can decide which providers should be global and which should be defined by the story itself. For example, I expect that SidebarProvider
is only used for sidebar components. Or DemoProvider
might need to be mocked to test components in different states
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Excited to get this in
Quality Gate passedIssues Measures |
🎉 This PR is included in version 1.14.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This is the first step of getting visual regression testing going. There will be follow up work to add more test cases and tweak the setup, so the goal of the PR is to find a good starting point
Description
How to test
You'll see some new checks on this PR: