feat: use featureFlagGroup claim for feature flags #329
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright test results
Details
Skipped testsNo persona › tests/auth.test.ts › authenticate through Clerk UI |
| }); | ||
|
|
||
| log.info("Bootstrapping feature flags", features); |
There was a problem hiding this comment.
Worth logging some of the new properties here?
There was a problem hiding this comment.
Nice idea. Will do
|
|
||
| const distinctId = userId ?? getDistinctIdFromCookie(headers) ?? "0"; | ||
| log.info("Evaluating feature flags for", distinctId); | ||
|
|
||
| const personProperties = sessionClaims?.labs?.featureFlagGroup |
There was a problem hiding this comment.
Is labs already decided? I believe we're using "aila" as the name for everything now
There was a problem hiding this comment.
Yeah, we already have a number of keys under labs. It comes from when the teacher squad started their proof of concept for Clerk. They have owa and we have labs. There's no reason why we can't change it, but we'd need some code to read both for a time
|
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
In #320 we added local evaluation of feature flags. Local evaluation calculates the feature flags for the user, but only has user data from the session token. That works for feature flags which are either on or off, but we sometimes want feature flags for a specific group of users, like the AI team or external testers
This work:
ai-teamfor the teamfeatureFlagGroupinto the feature flag evaluation, so that we can calculate the user's flags without needing their email addressTesting:
ai-teamai-teamset in clerk metadata (I've set it for all of our Oak emails)Bootstrapping feature flags { 'download-all-button': true }in the server logBootstrapping feature flags { 'download-all-button': false }in the server log