chore: error pages #327
Merged
chore: error pages #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Playwright test results
Details
Skipped testsNo persona › tests/auth.test.ts › authenticate through Clerk UI |
codeincontext
approved these changes
Oct 31, 2024
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deals with this convo https://www.notion.so/oaknationalacademy/Error-pages-4381e99e87214d4d9a1d9169d67363f9
The discussion raises a warning seen in the vercel logs about it not being able to fine _error.js which is a page that is deprecated when using the app router (which we are). The general solution I can see is to either ignore the warning (only a warning) or to add a _error.js page which is a bit nasty. I have however to save the warning added the _error.js page with a redirect to our global error handler. I am open to discussion here!
Along side this I have borrowed the styling from our 404 page for our global error page.