Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add types for SVG imports, remove unused #318

Merged
merged 3 commits into from
Nov 18, 2024
Merged

fix: add types for SVG imports, remove unused #318

merged 3 commits into from
Nov 18, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Oct 29, 2024

Description

  • Adds a type for the SVG imports
  • Removes unused inline SVG icons

@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 10:58am

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

Playwright test results

passed  14 passed
flaky  1 flaky
skipped  1 skipped

Details

report  Open report ↗︎
stats  16 tests across 15 suites
duration  2 minutes, 42 seconds
commit  81b5fb0

Flaky tests

No persona › tests/modifiy-lesson.test.ts › Modify a lesson plan › Modify a lesson resource

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI

@stefl stefl requested a review from a team October 30, 2024 09:53
codeincontext
codeincontext reviewed Oct 30, 2024
View reviewed changes
apps/nextjs/src/components/Icon/svgs.tsx
Comment on lines +76 to +83
type SVGImport = {
src: string;
height: number;
width: number;
blurDataURL: string;
blurWidth: number;
blurHeight: number;
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach does work, but there should be a way to set the type for svg imports. I know there is in webpack, not sure how to do it with turbopack

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codeincontext
Copy link
Collaborator

Merging this one as it's passing tests and is stale

@codeincontext codeincontext merged commit c1eff88 into main Nov 18, 2024
18 checks passed
@codeincontext codeincontext deleted the fix/types_for_svgs branch November 18, 2024 11:05
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.16.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeincontext codeincontext codeincontext approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefl @codeincontext @oak-machine-user