feat: add mobile layouts #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright e2e testsTo view traces locally, unzip the report and run: npx playwright show-report ~/Downloads/playwright-report |
tomwisecodes
force-pushed
the
feat/mobile
branch
from
67f264c to
2f90e33
Compare
mantagen
reviewed
Sep 2, 2024
| @@ -14,7 +14,9 @@ export function SurveyDialogLauncher() { | |||
| useEffect(() => { | |||
| if (survey) { | |||
| const timer = setTimeout(() => { | |||
| setDialogWindow("feedback"); | |||
| if (window.innerWidth < 768) { | |||
There was a problem hiding this comment.
Could 768 be a const somewhere?
apps/nextjs/src/app/layout.tsx
Outdated
| webDebuggerOptions: { | ||
| position: WebDebuggerPosition.BottomLeft({ | ||
| // stop this from being displayed at all |
There was a problem hiding this comment.
is this comment in wrong place?
There was a problem hiding this comment.
me getting rid of avo on every pr lol ill remove
| useState(false); | ||
|
|
||
| useEffect(() => { | ||
| console.log("ailaStreamingStatus", ailaStreamingStatus); |
|
|
||
| import { AilaStreamingStatus } from "@/components/AppComponents/Chat/Chat/hooks/useAilaStreamingStatus"; | ||
|
|
||
| export const useMobileLessonPullOutControl = ({ |
There was a problem hiding this comment.
What actually is the mobile lesson pullout? can't see it anywhere otherthan "close" or "user has overridden". Is it a component?
There was a problem hiding this comment.
It's the right-hand side that becomes a pull out for mobile
mantagen
approved these changes
Sep 2, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue(s)
Fixes #
How to test
Screenshots
How it used to look (delete if n/a):
{screenshots}
How it should now look:
{screenshots}
Checklist