Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: incrementally move Core not to use barrel files #290

Merged
merged 1 commit into from
Oct 29, 2024
Merged

chore: incrementally move Core not to use barrel files #290

merged 1 commit into from
Oct 29, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Oct 29, 2024

Description

  • This is part of our ESLint / barrel file work, focusing on just the Core package

@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 1:53pm

@stefl stefl requested a review from a team October 29, 2024 13:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
22.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Playwright test results

passed  13 passed
skipped  1 skipped

Details

report  Open report ↗︎
stats  14 tests across 13 suites
duration  1 minute, 48 seconds
commit  6cb5cda

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI

@stefl stefl merged commit 0b2b7c5 into main Oct 29, 2024
13 of 14 checks passed
@stefl stefl deleted the chore/inngest_client branch October 29, 2024 14:18
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeincontext codeincontext codeincontext approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefl @oak-machine-user @codeincontext