Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: incrementally move to Aila not using barrel files #289

Merged
merged 7 commits into from
Oct 29, 2024
Merged

chore: incrementally move to Aila not using barrel files #289

merged 7 commits into from
Oct 29, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Oct 29, 2024

Description

  • This refactors how we are importing from the Aila package and restructures some of the code so that we directly import the files that we care about

@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 2:46pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

Playwright test results

passed  13 passed
skipped  1 skipped

Details

report  Open report ↗︎
stats  14 tests across 13 suites
duration  1 minute, 48 seconds
commit  12add47

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI

@stefl stefl requested a review from a team October 29, 2024 13:43
@codeincontext codeincontext self-requested a review October 29, 2024 14:27
codeincontext
codeincontext approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@codeincontext codeincontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some functional changes have snuck in here relating to awaits, but they each seem ok 👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stefl stefl merged commit 548b85d into main Oct 29, 2024
14 checks passed
@stefl stefl deleted the fix/aila_barrel_files branch October 29, 2024 15:00
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeincontext codeincontext codeincontext approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefl @oak-machine-user @codeincontext