Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure we follow the eslint rule to use "import type" notation #285

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Oct 29, 2024

Description

  • This adds a new ESLint rule @typescript-eslint/consistent-type-imports which ensures that we use import type { ... } throughout

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 11:52am

@stefl stefl requested a review from a team October 29, 2024 11:34
Copy link

Playwright test results

passed  13 passed
skipped  1 skipped

Details

report  Open report ↗︎
stats  14 tests across 13 suites
duration  1 minute, 44 seconds
commit  da3d3ae

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI

@stefl stefl merged commit f9c93ec into main Oct 29, 2024
7 of 8 checks passed
@stefl stefl deleted the fix/eslint_import_type branch October 29, 2024 11:48
Copy link

@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants