Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip Github workflows that depend on PR ID when PR doesn't exist #28

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

codeincontext
Copy link
Collaborator

@codeincontext codeincontext commented Aug 29, 2024

Description

Two of our Github workflows are triggered by successful deployments, and then search for a PR with that SHA. They both fail if a branch is pushed before the PR is created

  • Skip GH actions that rely on the PR number if it's missing

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 2:29pm

Copy link

@codeincontext codeincontext marked this pull request as ready for review August 29, 2024 14:32
Copy link
Collaborator

@simonrose121 simonrose121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@codeincontext codeincontext merged commit 523fd31 into main Aug 29, 2024
14 checks passed
@codeincontext codeincontext deleted the chore/playwright-skip-comment branch August 29, 2024 14:34
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants