fix: remaining linting fixes

[stefl]

Description

This is the remaining linting work that has since been merged through other PRs.

• By being more specific about imports and including types, this aims to reduce how much code has to be processed in builds, potentially reducing test run times and dev server start times, and potentially improve production performance because of smaller bundle sizes

Code conventions:

• Reintroduces our custom eslint rules with everything set to "warn". Somehow this had got disabled at some point.
• Adds @typescript-eslint/consistent-type-imports so that we import with import type where appropriate (and VS Code will automatically do this for us)

Aila package:

• Disables Americanism detection unless you externally initialise it
• Removes barrel imports and adjust Aila imports to import the appropriate package
• Fixes some tricky edge cases with the Aila package as a result (failing to await promises when in an error state in streaming, etc.)
• Allows us to pass in externally-initialised analytics adapters into the package at intialisation, so we don't always have to import all dependencies for every adapter

The touched files count looks high but it's primarily altering import statements throughout

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
oak-ai-lesson-assistant	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 30, 2024 4:04pm

[github-actions]

Playwright test results

 13 passed
 1 skipped

Details

 Open report ↗︎
 14 tests across 13 suites
 1 minute, 52 seconds
 8e0b803

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI

[codeincontext]

This is good work

The import changes make sense to me. I don't think they will be fully effective unless we encourage us to continue using the pattern. I think we should remove any export * from ... code so our autosuggest doesn't get tempted to do the wrong thing

The aila changes are really good. I wonder if we will start to need some JSdoc comments on the options so that it's clear what the options are that you can provide when configuring it

Importing inngest at test runtime - not one I'm convinced by at the moment. First off, I don't understand the underlying reason why it would improve performance. Secondly, I don't know if it applies to other packages, other test files, or when we would be able to remove the fix. It would help to see that in a different PR so we can look at a before/ after and get a better understanding of what it's doing and if it's still needed

[stefl]

This is good work

The import changes make sense to me. I don't think they will be fully effective unless we encourage us to continue using the pattern. I think we should remove any export * from ... code so our autosuggest doesn't get tempted to do the wrong thing

The aila changes are really good. I wonder if we will start to need some JSdoc comments on the options so that it's clear what the options are that you can provide when configuring it

Importing inngest at test runtime - not one I'm convinced by at the moment. First off, I don't understand the underlying reason why it would improve performance. Secondly, I don't know if it applies to other packages, other test files, or when we would be able to remove the fix. It would help to see that in a different PR so we can look at a before/ after and get a better understanding of what it's doing and if it's still needed

Thanks - I've reverted the inngest import change. A good point about adding jsdoc. Before we go for that, I think we need to look again at the feature factory approach - irrespective of which adapter we use, we are automatically importing all dependencies for all adapters, which feels like something to fix in a separate piece of work. That could change the pattern for how we do this.

[stefl]

Move this function to the body

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[oak-machine-user]

🎉 This PR is included in version 1.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀